Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0.1 formatting - lost indentation of arguments (fine in 8.x) #311

Closed
nightroman opened this issue Apr 21, 2023 · 4 comments · Fixed by #312
Closed

9.0.1 formatting - lost indentation of arguments (fine in 8.x) #311

nightroman opened this issue Apr 21, 2023 · 4 comments · Fixed by #312
Labels
bug Something isn't working

Comments

@nightroman
Copy link

9.0.1 fixes some formatting issues -- #287
And introduces a new issue, lost indentation of field arguments.

Please find attached the project for reproducing the issue:
TryGraphQLParser.zip

Steps

x1-type.graphql was produced by 8.x formatting.
See expected indented arguments:

type Query {
  "Fetches an object given its ID."
  node(
    "ID of the object."
    id: ID!): Node
  "Lookup nodes by a list of IDs."
  nodes(
    "The list of node IDs."
    ids: [ID!]!): [Node]!

Run

dotnet run -- x1-type.graphql

This produces the new x1-type.graphql.output.graphql.
See unexpected not indented arguments:

type Query {
  "Fetches an object given its ID."
  node(
  "ID of the object."
  id: ID!): Node
  "Lookup nodes by a list of IDs."
  nodes(
  "The list of node IDs."
  ids: [ID!]!): [Node]!
@nightroman
Copy link
Author

Wow, that's fast, thank you. Looking forward to the new NuGet update!

@sungam3r
Copy link
Member

@sungam3r
Copy link
Member

Also see #314, I didn't fix all issues yet but the whole process does not seem difficult now.

@nightroman
Copy link
Author

@sungam3r Many thanks. All looks good now, beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants