Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Ready Selection API for Embedded Graphistry #149

Open
exrhizo opened this issue Oct 13, 2023 · 0 comments
Open

Production Ready Selection API for Embedded Graphistry #149

exrhizo opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@exrhizo
Copy link

exrhizo commented Oct 13, 2023

Prior work here: #144

See: storybook
Simple Demo App

The full API will be to export user viz selections to the parent frame and allow the user to set selections from the parent. Development has been paused.

Status:

  • OnLabelsUpdate are available but don't include id or any row data
  • OnSelectionUpdate requires flag_unsafe_jsapi_export_row nexus flag
    • unsafe because a 3rd party website could embed and do data exfiltration with phishing attack
    • Fix for that is using JWT token on the parent site to authenticate subscriptions
  • The API for setting selections is temp hack for prototyping
    • Parent needs to use selection to get mapping from data id to our local id to set based on those
    • Further work looking at performance impacts of sending large selections is relevant
    • Set selection involves how we store local vs global indices, node server or frontend cache of the mapping
@exrhizo exrhizo added the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant