Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instanceof Observable check #28

Open
blacktaxi opened this issue Jan 18, 2018 · 1 comment
Open

Fix instanceof Observable check #28

blacktaxi opened this issue Jan 18, 2018 · 1 comment

Comments

@blacktaxi
Copy link
Member

The current instanceof Observable check that is used in the implementation of lifted component relies on the class instance check, which in turn requires that the instance be checked against the same constructor it was created with.

However it is possible that user-created Observables come from a different version or just a different instance of the rxjs package. In that case the instanceof Observable check will always fail.

It seems that the issue of several rxjs packages in a bundle should not be affecting Focal, or if it does there should be a quick way to diagnose the issue.

One solution that I see is the adoption of symbol-observable check like it's done in Redux, etc.

@sukazavr
Copy link

I think, rxjs >= 6.3.0 doesn't work with focal 0.6.438 because of that.
Lift just can't recognize that some of the properties are an Observable instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants