Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximun number of spans for span sets #4275

Open
javiermolinar opened this issue Nov 4, 2024 · 1 comment
Open

Limit maximun number of spans for span sets #4275

javiermolinar opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels
area/query good first issue Good for newcomers type/docs Improvements or additions to documentation

Comments

@javiermolinar
Copy link
Contributor

javiermolinar commented Nov 4, 2024

Currently, there is no way to limit the number of spans per span set. This query is ok:

http://localhost:3200/api/search?q={}&spss=10000

This can destabilize Tempo. We should add a new config to control this. Tempo must return an error if the spss is greater than the aforementioned limit. This is similar to the limit behaviour

https://grafana.com/docs/tempo/latest/api_docs/#search

@javiermolinar javiermolinar self-assigned this Nov 4, 2024
@javiermolinar javiermolinar added good first issue Good for newcomers area/query type/docs Improvements or additions to documentation labels Nov 4, 2024
@knylander-grafana
Copy link
Contributor

Thanks for thinking about docs for this config update request. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query good first issue Good for newcomers type/docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants