-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve developer experience with ebpf testdata #3270
Comments
It looks like they are not used. Let's just remove them? (both cases)
|
We can also put modules into |
Either approach sounds good to me. Putting them in an archive will reduce the chance of the problem surfacing again in the future which would be nice. |
Also having a 4G git submodule may be not a great experience as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that the git submodule in
ebpf/testdata
, will always be marked changed when you are on a case-insensitive file system/volume:See wrong fix and discussion in #3254 and upsteam pyroscope-io/pyroscope-ebpf-testdata#4
Workaround (which is not ideally, as every new contributor has to run it):
I wonder what the best way forward:
cc @aleks-p @korniltsev
The text was updated successfully, but these errors were encountered: