Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir-build-image: Upgrade Go version to 1.23.1-bookworm #9288

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

JohnnyQQQQ
Copy link
Member

What this PR does

Upgrades Go version in mimir-build-image.

Which issue(s) this PR fixes or relates to

n/a

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@JohnnyQQQQ JohnnyQQQQ requested a review from a team as a code owner September 12, 2024 17:34
Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9288-97439b746b. This can take up to 1 hour.

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aknuds1
Copy link
Contributor

aknuds1 commented Sep 13, 2024

You should try force pushing an amend commit, to re-trigger the CI.

@JohnnyQQQQ JohnnyQQQQ force-pushed the update-go-version-build-image branch from 1e0a9e9 to fc73d4d Compare September 13, 2024 08:27
Copy link
Contributor

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9288-97439b746b already exists.

@aknuds1 aknuds1 enabled auto-merge (squash) September 13, 2024 08:47
@aknuds1 aknuds1 merged commit fb54e0d into main Sep 13, 2024
30 checks passed
@aknuds1 aknuds1 deleted the update-go-version-build-image branch September 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants