mimir-build-image: Upgrade golangci-lint #8385
Conversation
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
aknuds1
force-pushed
the
arve/upgrade-golangci-lint
branch
from
98d6f39 to
a29d34e
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
aknuds1
force-pushed
the
arve/upgrade-golangci-lint
branch
from
a29d34e to
1002687
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/upgrade-golangci-lint
branch
from
ff4648e to
5797548
Compare
|
Not building new version of mimir-build-image. This PR modifies |
aknuds1
requested review from
wilfriedroset,
vaxvms,
bubu11e and
a team
as code owners
Signed-off-by: Arve Knudsen <[email protected]> (cherry picked from commit 4c02b83)
What this PR does
Upgrade to golangci-lint v1.59.1.
An issue with this upgrade is that
staticchecknow complains aboutreflect.*Headerbeing deprecated. I fix it in one test, since it was easy, but leave other cases ignored by the linter (nolint:staticcheck) to unblock the PR.pkg/mimirpb/timeseries_test.go:108:25: SA1019: reflect.SliceHeader has been deprecated since Go 1.21 and an alternative has been available since Go 1.17: Use unsafe.Slice or unsafe.SliceData instead. (staticcheck)Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.