Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Skopeo in build image to latest version #8347

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

charleskorn
Copy link
Contributor

What this PR does

GitHub Actions has started rolling out a new runner image, which uses Docker v26.

The previous runner image used Docker v24.

Older versions of Skopeo are not compatible with Docker v25+ (see this comment), which causes CI failures if the integration tests run on a runner with the new image (example).

This PR bumps Scopeo to the latest available version.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr8347-55c99be7fb. This can take up to 1 hour.

@charleskorn charleskorn marked this pull request as ready for review June 12, 2024 04:42
@charleskorn charleskorn requested a review from a team as a code owner June 12, 2024 04:42
@charleskorn charleskorn enabled auto-merge (squash) June 12, 2024 05:21
@charleskorn charleskorn disabled auto-merge June 12, 2024 06:21
@charleskorn charleskorn enabled auto-merge (squash) June 12, 2024 06:24
Copy link
Contributor

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8347-55c99be7fb already exists.

@charleskorn charleskorn merged commit 916bbd9 into main Jun 12, 2024
30 checks passed
@charleskorn charleskorn deleted the charleskorn/bump-skopeo branch June 12, 2024 07:01
@pstibrany
Copy link
Member

Follow-up in #8355

grafanabot pushed a commit that referenced this pull request Jun 13, 2024
* Bump Skopeo in build image to latest version

* Update build image version to pr8347-55c99be7fb

* Trigger Build

(cherry picked from commit 916bbd9)
charleskorn added a commit that referenced this pull request Jun 14, 2024
* Bump Skopeo in build image to latest version (#8347)

* Bump Skopeo in build image to latest version

* Update build image version to pr8347-55c99be7fb

* Trigger Build

(cherry picked from commit 916bbd9)

* Update build image version to pr8368-55c99be7fb

* Trigger CI

---------

Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: grafanabot <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants