mimir-build-image: Upgrade to google.golang.org/protobuf/cmd/[email protected] #6541
Conversation
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6541-d2a96ab505`. This can take up to 1 hour. |
|
Can we do all the changes in single PR (thinking of #6540), otherwise there will be lot of rebasing and image rebuilding going on. |
|
@pstibrany I wanted to get this image built and try to regenerate *.pb.go files with it. If you prefer it, I can fuse into one PR, sure. |
I think it would have been easier, but feel free to do it your way. |
|
I was hoping to get rid of github.com/golang/protobuf references in *.pb.go files, but no dice. Theory is these are generated by github.com/gogo/protobuf/protoc-gen-gogoslick, so we'd have to migrate off gogo also. |
aknuds1
force-pushed
the
arve/protobuf
branch
from
6ea48f0 to
3ad5430
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6541-9a9d7c46fb`. This can take up to 1 hour. |
aknuds1
force-pushed
the
arve/protobuf
branch
from
f940927 to
931d4d3
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
…[email protected] Signed-off-by: Arve Knudsen <[email protected]>
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
What this PR does
Upgrade build image to google.golang.org/protobuf/cmd/[email protected], since github.com/golang/protobuf/protoc-gen-go is deprecated.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]