Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: retry label values and names requests in the query-frontend #10037

Open
dimitarvdimitrov opened this issue Nov 28, 2024 · 0 comments
Open
Labels

Comments

@dimitarvdimitrov
Copy link
Contributor

dimitarvdimitrov commented Nov 28, 2024

What is the problem you are trying to solve?

A transient failure for a label names or values query is directly returned to the user.

Which solution do you envision (roughly)?

Extend the middleware machinery so that we can reuse the retry middleware on labels requests too. Currently it can't be directly reused because middlewares are only working with MetricsQueryRequest.

Maybe we should make retry generic so that it works with LabelsQueryRequest too.

Have you considered any alternatives?

Implement a retry round-tripper and wrap the labels round-tripper. This will duplicate code and will require us to keep the two implementations in sync. I think we were also trying to steer away from round-trippers. See #7536, https://github.com/grafana/mimir-squad/issues/1938

Any additional context to share?

No response

How long do you think this would take to be developed?

Small (<= 1 month dev)

What are the documentation dependencies?

No response

Proposer?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant