-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path normalisation/Stripping leading slashes #533
Comments
I'm accepting PR's for this. |
Leaving that for whomever wants to take it. Caveats, testing is a bit of a chore, while at it, it's worth checking why a new gin engine is created from scratch rather than |
hey can i work on this issue ? |
@shubmjagtap Yes, but make sure to test this with different reverse proxy configurations, that it'll work correctly. |
Is your feature request related to a problem? Please describe.
When working with a relatively naive setup of gotify, one may have a trailing slash when specifying the url of the host (
http://localhost/
instead ofhttp://localhost
for example).To avoid any issues/ambiguity, the developer using this URL should append
/message
to the configured url to send a message regardless of the url specified by the customer to ensure that a slash is in there.This can lead to the fully formed looking like this
http://localhost//mesage
, unfortunately with the way gotify is currently built, the double slash is not normalised and a query at this URL will lead to a 404Describe the solution you'd like
Gotify should normalise the URL it receives to deduplicate slashes when possible, those are not meant to have any bearing on the URL.
Describe alternatives you've considered
The alternative is to leave with misconfigurations and hope they are being detected early on by the API user.
The text was updated successfully, but these errors were encountered: