Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remove StateData trait #488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lucacasonato
Copy link
Contributor

Closes #487.

This PR is still WIP, because documentation has not been updated yet. If this RFC is accepted, I will update the related docs.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #488 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   84.90%   85.04%   +0.14%     
==========================================
  Files         109      108       -1     
  Lines        5599     5598       -1     
==========================================
+ Hits         4754     4761       +7     
+ Misses        845      837       -8     
Impacted Files Coverage Δ
gotham/src/extractor/path.rs 66.66% <ø> (ø)
gotham/src/extractor/query_string.rs 66.66% <ø> (ø)
gotham/src/handler/assets/mod.rs 92.61% <ø> (ø)
gotham/src/middleware/session/mod.rs 79.34% <ø> (ø)
gotham/src/middleware/state/mod.rs 100.00% <ø> (ø)
gotham/src/pipeline/mod.rs 98.07% <ø> (ø)
gotham/src/router/builder/associated.rs 48.88% <ø> (ø)
gotham/src/router/builder/mod.rs 97.17% <ø> (ø)
gotham/src/router/builder/single.rs 94.11% <ø> (ø)
gotham/src/router/route/dispatch.rs 94.54% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcf5b1...7422296. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: remove StateData trait
2 participants