Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/deb package changes #612

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feature/deb package changes #612

wants to merge 12 commits into from

Conversation

ArtemTrofimushkin
Copy link

Fixes #488

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2023
@ArtemTrofimushkin ArtemTrofimushkin mentioned this pull request Jan 30, 2023
Open
2 tasks
@erikgeiser
Copy link
Member

Thanks for the PR. I didn't have time to read it completely, yet, but I took a glance at the changes. Maybe Distribution and Urgency should be required to set. I'm not sure that setting them automatically to unstable and medium makes sense as we don't even know what is being packaged and for which distro. If people want the metadata these values should probably be deliberate.

@ArtemTrofimushkin
Copy link
Author

@erikgeiser Thanks for the explanation.
Updated the PR to make these fields required (removed default values in SetPackagerDefaults)

caarlos0
caarlos0 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for the PR, sorry I missed it earlier...

this LGTM, I believe its only missing the docs changes... can you add them too?

Thanks!

@caarlos0 caarlos0 added the enhancement New feature or request label Apr 5, 2023
@caarlos0 caarlos0 modified the milestones: v2.35.0, 2.36.0 Dec 17, 2023
@caarlos0 caarlos0 modified the milestones: 2.36.0, 2.37.0, 2.38.0 May 8, 2024
@caarlos0
Copy link
Member

caarlos0 commented Jul 6, 2024

hey! sorry for the delay reviewing this...

lets merge it with main and get it in for v2.39?

@caarlos0 caarlos0 modified the milestones: 2.38.0, 2.39.0 Jul 6, 2024
@ArtemTrofimushkin
feat: add extensibility point
6c13bcf 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: add changes template
974163d 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: implement draft for deb changes file
715f71d 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: fix changes template generation
b3eba1b 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: fix changes template generation & extract required fields to se…
01c2806 
…parate struct

Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: implement signing for deb changes file
f239d93 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: implement tests for deb meta
5fa17d9 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
feat: fix linting issues
6d78b49 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin
fix: drop defaults for urgency/distribution
15fa92e 
Signed-off-by: ArtemTrofimushkin <[email protected]>
@ArtemTrofimushkin ArtemTrofimushkin force-pushed the feature/deb-package-changes branch from f5515f6 to 15fa92e Compare September 4, 2024 11:11
@ArtemTrofimushkin
Copy link
Author

Hello @caarlos0 !
I'm very sorry for loong delay, let's try to merge changes?

@caarlos0
Copy link
Member

caarlos0 commented Sep 5, 2024

hey, seems like there are some tests failing, can you take a look?

@ArtemTrofimushkin
Copy link
Author

@caarlos0 all fixed. Locally all tests passed. Can you run all checks again?

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.82278% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (db338d0) to head (708cb47).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/package.go 0.00% 17 Missing ⚠️
deb/deb_meta.go 82.75% 5 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   73.16%   72.91%   -0.25%     
==========================================
  Files          22       23       +1     
  Lines        2493     2570      +77     
==========================================
+ Hits         1824     1874      +50     
- Misses        463      485      +22     
- Partials      206      211       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2.39.0
Development

Successfully merging this pull request may close these issues.

Generate .changes files for debian packages
3 participants
@ArtemTrofimushkin @erikgeiser @caarlos0