Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum SHA length in the changelog #4829

Open
3 of 4 tasks
vaerh opened this issue May 3, 2024 · 2 comments
Open
3 of 4 tasks

Maximum SHA length in the changelog #4829

vaerh opened this issue May 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@vaerh
Copy link

vaerh commented May 3, 2024

What happened?

Hello!
Is it possible to get the full hash of a commit in the CHANGELOG.md?
Current implementation doesn't allow to get more than 7 characters (option --abbrev-commit).

  • generating changelog
    • git command result                             args=[-c log.showSignature=false log --pretty=oneline --abbrev-commit --no-decorate --no-color 958bbb194da3f8359e9a245cad803ae742710da3 v1.0.0] stdout=879d5a3 chore(release): 1.0.0
cat dist/CHANGELOG.md
## Changelog
* 958bbb1 feat: Test

args := []string{"log", "--pretty=oneline", "--abbrev-commit", "--no-decorate", "--no-color"}

How can we reproduce this?

changelog:
use: git
abbrev: 10

goreleaser version

GitVersion:    1.26.0-nightly
GitCommit:     1ec2e1628889bd2b466d2760c536d73b0c9a2aaf
GitTreeState:  false
BuildDate:     2024-04-25T01:25:48Z
BuiltBy:       goreleaser
GoVersion:     go1.22.2
Compiler:      gc
ModuleSum:     unknown
Platform:      linux/amd64

git version 2.39.2

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@vaerh vaerh added bug Something isn't working triage Issue pending triage by one of the maintainers labels May 3, 2024
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label May 3, 2024
@caarlos0
Copy link
Member

caarlos0 commented May 3, 2024

we can do that, but if I remember correctly, github will still show only the short sha in the release notes.

anyway, I can see this being useful for other people anyway. will improve it!

thanks for the issue!

@vaerh
Copy link
Author

vaerh commented May 3, 2024

Carlos, thank you!
It's part of CI/CD with a local git repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants