Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in jupyter qtconsole #224

Open
mackong opened this issue Dec 22, 2020 · 3 comments · Fixed by #230
Open

Broken in jupyter qtconsole #224

mackong opened this issue Dec 22, 2020 · 3 comments · Fixed by #230

Comments

@mackong
Copy link
Contributor

mackong commented Dec 22, 2020

When start in qtconsole like

jupyter-qtconsole --kernel=gophernotes

Enter pressed, the terminal show following messages:

2020/12/22 19:19:46 Unhandled shell message:  history_request
2020/12/22 19:19:50 Unhandled shell message:  is_complete_request

and statement is not executed.

VERSIONS:
jupyter core : 4.7.0
jupyter-notebook : 6.1.5
qtconsole : 4.7.7
ipython : 7.19.0
ipykernel : 5.3.4
jupyter client : 6.1.7
jupyter lab : 2.2.9
nbconvert : 6.0.7
ipywidgets : not installed
nbformat : 5.0.8
traitlets : 5.0.5

@cosmos72
Copy link
Member

cosmos72 commented Mar 3, 2021

To be honest, I have never tried jupyter-qtconsole

Thanks for the report and the pull request, I will try jupyter-qtconsole with your fix

@cosmos72 cosmos72 reopened this Apr 13, 2021
@cosmos72
Copy link
Member

After merging your pull request, I added commit df600ce to distinguish between incomplete and invalid input.

I also noticed that jupyter-qtconsole inserts any error after the prompt, then inserts a newline, forcing the user to delete the error with backspaces before entering new input - does it happen to you as well?

@mackong
Copy link
Contributor Author

mackong commented Jul 23, 2021

Yes, same behaviour here.

Seems it is caused by reply message arrived before error message.

I tried to fix this, but I don't know how to control the order of IOPub channel and Shell channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants