-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gofmt formatter doesn't clear quickfix list when all errors are fixed #58
Comments
Interesting… I wonder if it's normal to clear setqflist. For instance, should it be cleared for any formatter, even formatters that don't support populating the quickfix list? I definitely think we should close it if we're not doing that. |
I ran into this again today, while working on #103. We now have several occurrences of the "if found errors, |
Yeah, SGTM. |
(Forwarding a report from someone else)
I am using the codefmt plugin for Go, by including:
And it looks like it doesn't clear the quick fix list when all errors are fixed. E.g.:
I have 3 errors, and if I save, the quick fix window shows the three of them.
If I fix 1, and save, the quick fix window correctly shows only two of them.
If now I fix the 2 remaining ones, and save, the quick fix window doesn't update at all.
It looks like we only call "setqflist" in the case of errors:
https://github.com/google/vim-codefmt/blob/master/autoload/codefmt.vim#L320
but never clear it if there are no errors.
The text was updated successfully, but these errors were encountered: