Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Code examples for using TFRecorder TFRecords in a tf.data.Dataset #12

Open
mbernico opened this issue Aug 3, 2020 · 4 comments
Open
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@mbernico
Copy link
Contributor

mbernico commented Aug 3, 2020

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
As a user I would like to see an example of how to read the output of TFRecorder in as a tf.data.Dataset.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mbernico mbernico added the enhancement New feature or request label Aug 3, 2020
@mbernico mbernico self-assigned this Aug 3, 2020
@jmarrietar
Copy link
Contributor

Hi @mbernico !, regarding the code examples in Jupyter Notebook documentation. A nice to have feature would be the ability to open them in a colab environment. Maybe adding a Badge like this Open In Colab .

thoughts? :)

@mbernico
Copy link
Contributor Author

Hey jmarrietar, yeah, I think this makes a lot of sense. Would you mind adding it as a separate issue? Also if you wanted to pull request it we'd love that too, if not we can for sure get to it.

Lastly, would you mind taking a look at the flexible schema PR #20 I think it's useful, but it does make the codebase more complicated so I'd love some feedback before we merge it.

@jmarrietar
Copy link
Contributor

jmarrietar commented Sep 22, 2020

Hey jmarrietar, yeah, I think this makes a lot of sense. Would you mind adding it as a separate issue? Also if you wanted to pull request it we'd love that too, if not we can for sure get to it.

Lastly, would you mind taking a look at the flexible schema PR #20 I think it's useful, but it does make the codebase more complicated so I'd love some feedback before we merge it.

Just created Issue #27 as a separated one. I didn't Assign it to me just yet since I might be short of time right now. But would like to take it soon. Cheers! :)

@mbernico
Copy link
Contributor Author

Ok, cool, I put it in my name but feel free to take it on :)

@cfezequiel cfezequiel added the documentation Improvements or additions to documentation label Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants