New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ifuzz/x86: potential issues with instruction decoding #4769
Comments
If you introduce randomness into tests, please use this thing: It provides both determinism for CI coverage/failures, random seeds in local testing and ability to reproduce with particular seed. |
Yeah, I looked into it, but it is a bit tricky to inject a random source into Register(), which constructs the InsnSet. Perhaps I should add an |
Some test-only hook that will permute instructions looks better. |
pkg/ifuzz/x86 does not fully implement instruction decoding, ignoring some of the opcode field combinations.
Because of that, there can be ambiguity in instruction parsing, that depends on the order of the instructions in
insnset
.Such problems can be triggered by shuffling the instructions at registration time:
The text was updated successfully, but these errors were encountered: