New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prog: switch to math/rand/v2 #4751
Comments
If we stick to the rule that our |
We could diverge from that rule for a short period of time. Nobody really asked us for 2 versions. Just spotted this: |
What are the potential side effects assuming we want to remove syz-old-env? |
At the very least we want to make sure that newer syzkaller revisions are buildable and testable by the currently running syz-ci's in the current docker images. There's also FreeBSD (and probably something else), where we don't use docker containers at all, so we should be mindful of everything that breaks once we start using newer Go features. Otherwise, I can't think of any other benefits of the syz-old-env tests. |
We extensively use
math/rand
, but there are some performance issues with it:https://go.dev/blog/randv2
Perhaps if we switch all pacakges (prog, fuzzer, etc) to
math/rand/v2
we can get some perf wins.It was added in Go 1.22, so need to fix #4746 first.
The text was updated successfully, but these errors were encountered: