New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syz-fuzzer: repair leak checking #4728
Labels
Comments
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
May 23, 2024
Notify fuzzer from the manager when corpus triage has finished to start leak checking. Fixes google#4728
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
May 23, 2024
Ipc gate slows down overall execution a lot. Without ipc gate I am getting ~20% more executions with debug kernel and ~100% more executions with a fast non-debug kernel. Replace ipc gate with explicit tracking of last executing programs per proc in syz-manager. Ipc gate was also used for leak checking, but leak checking seems to be still broken. At least in my local runs I am not getting any leaks even with the previous fix. So remove the gate completly for now. Taking into account that we are likely to rewrite this code in C++ soon, it makes little sense to create a special gate for leak checking only in Go. Update google#4728
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
May 25, 2024
Notify fuzzer from the manager when corpus triage has finished to start leak checking. Fixes google#4728
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
May 25, 2024
Ipc gate slows down overall execution a lot. Without ipc gate I am getting ~20% more executions with debug kernel and ~100% more executions with a fast non-debug kernel. Replace ipc gate with explicit tracking of last executing programs per proc in syz-manager. Ipc gate was also used for leak checking, but leak checking seems to be still broken. At least in my local runs I am not getting any leaks even with the previous fix. So remove the gate completly for now. Taking into account that we are likely to rewrite this code in C++ soon, it makes little sense to create a special gate for leak checking only in Go. Update google#4728
dvyukov
added a commit
to dvyukov/syzkaller
that referenced
this issue
May 25, 2024
Ipc gate slows down overall execution a lot. Without ipc gate I am getting ~20% more executions with debug kernel and ~100% more executions with a fast non-debug kernel. Replace ipc gate with explicit tracking of last executing programs per proc in syz-manager. Ipc gate was also used for leak checking, but leak checking seems to be still broken. At least in my local runs I am not getting any leaks even with the previous fix. So remove the gate completly for now. Taking into account that we are likely to rewrite this code in C++ soon, it makes little sense to create a special gate for leak checking only in Go. Update google#4728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We stopped getting leak bugs: ci-upstream-gce-leak
Need to repair triagedCandidates logic in syz-fuzzer.
The text was updated successfully, but these errors were encountered: