Android. Process ARGB and Grayscale input packets #5018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5017
points to the issue of incorrect bitmap conversion in
Android when RGBA or Grayscale images are used.
As far as the library allows the creation of ALPHA8 bitmaps,
it is not enough to use only
getBitmapFromRgb
andgetBitmapFromRgba
,so the new
getBitmapFromAlpha
method is needed.Otherwise, existing users relying on the 8-bit input but not using the
input packet would catch errors despite their code operating as
intended.
Add correct processing of images with 1, 3, and 4 channels
to
FaceDetector
,FaceLandmarker
,FaceStylizer
,GestureRecognizer
,HandLandmarker
,HolisticLandmarker
,ImageClassifier
,ImageEmbedder
,ImageSegmenter
,InteractiveSegmenter
,ObjectDetector
, andPoseLandmarker
.If the number of channels is not 1, 3, or 4,
throw MediaPipeException with
INVALID_ARGUMENT
status code.Implement methods and functions needed to convert single-channel images
to RGBA bitmaps.
The native function
AlphaToRGBA
usesmemset
to set all bytes of the resulting buffer to zeros
and then copies the alpha values of the input image to the alpha values
of the corresponding output pixels.
Perform a slight refactoring:
use
operator[i]
instead of*(array + i)
for clarity.