Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to install-action #78

Open
mgeisler opened this issue Sep 13, 2023 · 5 comments
Open

Add to install-action #78

mgeisler opened this issue Sep 13, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mgeisler
Copy link
Collaborator

It would be cool if one could install mdbook-i18n-helpers using install-action.

@mgeisler mgeisler added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Sep 13, 2023
@miroim
Copy link

miroim commented Sep 18, 2023

Hi @mgeisler , I am interested in working on this.

According to the guide, releases are needed to generate the manifest.Would it be possible to include binaries for Windows, macOS, and Linux in future releases (#79)? This would make it much easier to add mdbook-i18n-helpers to install-action.

Please let me know if I'm wrong or need some other resources.

@mgeisler
Copy link
Collaborator Author

Hi @miroim, nice to meet you!

Thanks for looking into this. I agree we should generate binaries as part of the release — could you look into how people normally do that?

My Rust projects have mostly been libraries so far, and there nobody asked for binaries to be released 🙂

I use https://github.com/mgeisler/rust-release-gh-action for releasing my libraries and I would like to use it here too (eventually). Right now, the action requires a lib.rs file,p but that is something which should be fixed.

@miroim
Copy link

miroim commented Sep 19, 2023

Thank you for sharing your thoughts.

Typically, binaries for different platforms are generated within the CI pipeline. This ensures that the binaries are built automatically and are readily available for each release.
To make sure everything works as expected, I'll first conduct tests in the forked repository before integrating any changes into the main project.

@mgeisler
Copy link
Collaborator Author

To make sure everything works as expected, I'll first conduct tests in the forked repository before integrating any changes into the main project.

That's the best way for this kind of thing! Then you can (force-)push as much as you want and get quick feedback!

@simonsan
Copy link

simonsan commented Sep 20, 2023

This is from our nightly release pipeline:
https://github.com/rustic-rs/rustic_scheduler/blob/main/.github/workflows/nightly.yml
https://github.com/rustic-rs/create-binary-artifact-action/blob/main/action.yml

For inspiration:

  • this uses a build matrix and cross-compilation
  • this builds our binaries
    - compresses them with upx,
  • packages them to tar.gz
  • hashes them
  • signs them with pgp and rsign2
  • and then uploads them to a nightly repository

I'm currently adapting all of that for building a tag after releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants