Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let mdbook-xgettext generate a file in the same format as msgmerge #32

Open
mgeisler opened this issue Jun 1, 2023 · 1 comment
Open

Let mdbook-xgettext generate a file in the same format as msgmerge #32

mgeisler opened this issue Jun 1, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented Jun 1, 2023

Today, mdbook-xgettext outputs a PO file which looks different from what msgmerge outputs. The result is that translators get a huge diff the first time they run msgmerge. This is confusing, e.g., see the question in google/comprehensive-rust#743 (comment). It is also annoying since it prevents people from reviewing the changes.
@mgeisler mgeisler mentioned this issue Jun 1, 2023
Merged
@mgeisler mgeisler added the good first issue Good for newcomers label Jun 15, 2023
@mgeisler mgeisler added the enhancement New feature or request label Aug 14, 2023
@mgeisler mgeisler added the help wanted Extra attention is needed label Aug 24, 2023
mgeisler added a commit that referenced this issue Oct 2, 2023
@mgeisler
Wrap the source lines like msgmerge does
e680e80 
This will reduce churn between the output of `mdbook-xgettext` and
`msgmerge`. See google/comprehensive-rust#1245
for an example PR which would shrink with this feature.

Part of #32, but we still have differences in the way the messages
themselves are wrapped.
@mgeisler mgeisler mentioned this issue Oct 2, 2023
Open
@mgeisler
Copy link
Collaborator Author

mgeisler commented Oct 2, 2023

The changes for this should ideally be made in polib: BrettDong/polib#8.

This was referenced Oct 2, 2023
Merged
Merged
mgeisler added a commit that referenced this issue Nov 10, 2023
@mgeisler
Wrap source lines in mdbook-i18n-normalize
251f6d0 
Noticed by @henrif75 in
google/comprehensive-rust#317.

Part of #32 and a followup to #93.
@mgeisler mgeisler mentioned this issue Nov 10, 2023
Merged
mgeisler added a commit that referenced this issue Nov 10, 2023
@mgeisler
Wrap source lines in mdbook-i18n-normalize
c6b77a8 
Noticed by @henrif75 in
google/comprehensive-rust#317.

Part of #32 and a followup to #93.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgeisler