Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The script to update this repo have been broken since February - All new icons since then are completely missing from the variable material symbols fonts ttf files. #1706

Closed
timmaffett opened this issue Apr 1, 2024 · 20 comments

Comments

@timmaffett
Copy link

timmaffett commented Apr 1, 2024

I received a bug report about a missing keep_off icon from the flutter material_symbols_icons package. This was unexpected because the icon references are automatically generated from the material symbols icont ttf font files.

In investigating the problem I discovered that all of the 'keep' related icons are missing from the font files for the material symbols icons.
Checking things further I see that keep_public was present back in october, but in subsequent versions of the variable fonts files it went missing. keep and keep_off seem to have never been included over that last ~year that I went back.

See icons here from https://fonts.google.com/icons

Examining the font ttf files with ttx will show that these icons are completely missing from the fonts.

@tphinney
Copy link
Collaborator

tphinney commented Apr 1, 2024

I am not finding an internal issue for this, but this is familiar, and I do see that the "keep" related icons were missing (from the external Material Symbols) for a while, and reappeared some time in February. Anything based on font builds from the past month should have them, though!

You can see them at https://fonts.google.com/icons?icon.query=keep as well

@timmaffett
Copy link
Author

@tphinney The variablefont directory's true type fonts have not been updated since Feb 1. The fonts there currently do not have any keep related icons.
Could we get another release there so that we are in sync with the internal versions and have the keep related icons ?

@tphinney
Copy link
Collaborator

tphinney commented Apr 2, 2024

there are plenty of new icons missing as well, then

@tphinney
Copy link
Collaborator

tphinney commented Apr 2, 2024

Looking into getting that unstuck

@timmaffett
Copy link
Author

I have been wondering what was going on. 😆 Here's to hoping for getting the actions unstuck 🤞

@timmaffett
Copy link
Author

@tphinney Any word on this ?
I am sure you are also at the whims of the powers that be over this.. I was just hoping someone could trigger the job by now and we could get at all your wonderful new icons!

@tphinney
Copy link
Collaborator

I found an automated process that is not updating as it is supposed to, and am looking for help fixing it.

@timmaffett
Copy link
Author

Thanks @tphinney - that is what I had gathered. I am sure it is as frustrating to you as it is to all of us.

Is @EsoFromTheEast no longer available to help push things to the repo ?

My backup plan is to us the woff2 fonts from the https://fonts.gstatic.com/s/materialsymbolsXXXX/ directories if this repo cannot be brought up to date in a reasonable timeframe. At least that would allow us to move forward with using the updated fonts from some source we can access.

@EskelCz
Copy link

EskelCz commented Apr 15, 2024

@tphinney Thanks for looking into it, I'm waiting for these as well :)

@EskelCz
Copy link

EskelCz commented Apr 23, 2024

@tphinney Please do you have an ETA on this? We have a release next week and I was hoping the pin icon would be available by then. Thanks

@jeanpaulattard
Copy link

Hello gentlemen, was there any progress on this please? Thank you!

@EskelCz
Copy link

EskelCz commented Apr 25, 2024

mail_off is missing as well :(

Seems like this repo could use some help with maintenance. I would love to, but would I have to apply for a job at Google?
Could you maybe open source it?

@timmaffett
Copy link
Author

@EskelCz There are actually a number of icons that are missing now as the pipeline to update the external repo has been broken now since the beginning of February.

@tphinney I know that this is not in your control but is there anyone from google that we could add to this thread to try and get this fixed ? 🙏 I would be willing to do whatever work was required to figure this out but am I correct in thinking that the problem is in an google internal repo's actions that are failing and not updating this repo ?

@timmaffett timmaffett changed the title The icons keep, keep_off and keep_public code points are completely missing from the variable material symbols fonts ttf files. The script to update this repo have been broken since February - All new icons since then are completely missing from the variable material symbols fonts ttf files. Apr 26, 2024
@timmaffett
Copy link
Author

@tphinney Are you still working on Material Symbols Thomas ? I was just wondering with all the shake ups we here about with Google. I understand everyone is probably under increased stress under the circumstances, but it has now been 1/4 of a year since we had the benefit of the pipeline supplying your work to this repo. This there any hope that we can get this resolved ?

I have investigated writing a program to extract the TTF font from the (still being updated) WOFF fonts on https://fonts.google.com/icons . It is possible but I have to map symbol names from the ttf files back to symbol names used for the icons. For new icons this is not entirely ideal - but perhaps this will be the only way to get the updated icons going forward ?

@tphinney
Copy link
Collaborator

tphinney commented May 3, 2024

@timmaffett Yes, I am still here (as a contractor, not a Google staffer per se).

By coincidence, right at the same time you wrote that, I was listing this very issue for some other folks. No ETA yet.

@timmaffett
Copy link
Author

@tphinney That's great news - if you could please let us know when you find anything out. I feel like this must be a quick fix 🤞

@tphinney
Copy link
Collaborator

tphinney commented May 5, 2024

All done. Thanks TO @EsoFromTheEast

@EskelCz
Copy link

EskelCz commented May 5, 2024

All done. Thanks TO @EsoFromTheEast

It works! Thanks a lot to both of you.

@timmaffett
Copy link
Author

Thank you @tphinney for all your continuing work on the material symbols icons - and for motivating @EsoFromTheEast to take a look at the bug that was preventing the pipeline from working!

I really hope that it runs smoothly from here on out 😉

I have finally been able to publish a new release of the flutter material_symbols_icons package that is now up to date with version 2.741 of the official ttf fonts.

@jeanpaulattard
Copy link

Thank you all for fixing this. Really appreciate all the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants