Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web symbol for star doesn't have a non-fill version #1702

Open
joshjhall opened this issue Mar 26, 2024 · 6 comments
Open

Web symbol for star doesn't have a non-fill version #1702

joshjhall opened this issue Mar 26, 2024 · 6 comments
Assignees

Comments

@joshjhall
Copy link

Entirely possible I'm missing something, but it appears the web version of the star symbol SVG is incorrect. Both the fill and non-fill versions have the fill SVG. The iOS and Android versions appear correct, so possibly limited to how the web SVG was generated. I also haven't noticed the issue with any other symbols, so it might be quite limited in scope. Note, star_rate appears correct.

For example, for star @ style=rounded, weight=400, fill=off, grade=normal, optical size=24dp
Expected
CleanShot 2024-03-26 at 12 32 11@2x

File in symbols/web/star/materialsymbolsrounded/star_24px.svg shows
CleanShot 2024-03-26 at 12 36 10@2x

@joshjhall
Copy link
Author

The edit SVG also appears different than what's packaged in the font and such. Is the web SVG deprecated or out of date?

@tphinney
Copy link
Collaborator

Hmmm. I remember the default state for /star got changed a while back (as in, last year IIRC). Seems like maybe the SVG did not get regenerated.

/edit is also one that has been changed in the past year or so.

@EsoFromTheEast is this something you could address?

@joshjhall
Copy link
Author

Found another one this morning, emergency. May help track down when the SVG stopped regenerating.

@joshjhall
Copy link
Author

Thanks @tphinney and @EsoFromTheEast!

#1531 might be the same issue. It appears the SVG for pause is still out of date compared with the font and Figma sources as well.

@joshjhall
Copy link
Author

edit_document and star_half are also out of date

@tphinney
Copy link
Collaborator

tphinney commented May 5, 2024

This should at last be fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants