Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Generated annotation to all classes #26

Open
realityforge opened this issue Mar 23, 2019 · 0 comments
Open

Add @Generated annotation to all classes #26

realityforge opened this issue Mar 23, 2019 · 0 comments

Comments

@realityforge
Copy link
Contributor

It would be nice to annotate every generated class with @Generated annotation. This allows some IDEs to exclude these classes form certain code analysis. However, the jre standard @Generated was not introduced until java9 and Elemental2 is still supporting java8. In which case we could delay this change until java9 is the minimum supported version.

Alternatively, we could use the "enterprise java" @javax.annotations.Generated annotation but this would add a dependency solely for this annotation which seems sub-optimal. If we implement #25 and include @javax.annotations.Nonnull then the @javax.annotations.Generated annotation will be present in which case it would make sense to adopt this annotation for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant