Playwrite primary_language: question/discussion

[emmamarichal]

cc @vv-monsalve

I have the feeling that some of localised primary language like primary_language: "fr_Latn" doesn't work everywhere. For French, it works in the Guides versions, but not on the normal one. It's weird since both of metadata.pb have the primary_language set up.

For Argentina, Guides version isn't displayed in spanish, but I checked and the primary_language: "es_Latn" is missing from metadata.pb (same for Colombia)

[emmamarichal]

For Playwrite:

All the missing primary_languages have been added here: https://github.com/google/fonts/pull/7853/files

I checked, and only few of them are working:

The rest are displayed in english:

For Playwrite Guides:

Only Colombia and Argentina are missing

[vv-monsalve]

Hi @emmamarichal, what would be the question?

I have the feeling that some of localised primary language like primary_language: "fr_Latn" doesn't work everywhere. For French, it works in the Guides versions, but not on the normal one. It's weird since both of metadata.pb have the primary_language set up.

This is a UI issue. IIRC, I reported this in one of the meetings. However, it could be a good addition to the document for the problems to discuss with the ENG team.

All the missing primary_languages have been added here: https://github.com/google/fonts/pull/7853/files

They were not missing. I proposed adding this metadata field to localize the target language for these families.

Only Colombia and Argentina are missing

We missed this in the PR revision. I'll create a follow up PR with this fix.

[emmamarichal]

@vv-monsalve found the culprit! this PR has not be added to the traffic jam: #7853, I'm adding it!

[vv-monsalve]

That PR was not added to the board because the changes it introduced would be tracked by each of the 'ofl' directories moving through the pipeline at that time. That is each font PR. And the changes indeed landed, at least for most of the cases.

For instance, you can see that Playwrite BE WAL actually has the language information in the metadata field. But for some reason, Playwrite FR Moderne did not receive it, despite both being added in this commit of that PR.

Playwrite BE WAL

Playwrite FR Moderne

[emmamarichal]

Oh ok thanks! I updated my comment in the chat then :)

[vv-monsalve]

There is also a related issue regarding the primary_language.

It works okay on the landing page or when searching for them. However, once entering the desired font, the primary language stops working, and the Specimen page switches to English.

E.g. Playwrite Česko

• At first, it displays correctly the Czech language

  

• But in the Specimen page it is English

  

[vv-monsalve]

@vv-monsalve found the culprit! this PR has not be added to the traffic jam: #7853, I'm adding it!

@emmamarichal We'll need to add and track this PR after all.

I found another similar situation with the Deutschland models. They were added in this commit, however inspecting the metadata info for the distributed font the primary_language is empty, so the displayed text is still in English :/

So better to re-push that PR.

[emmamarichal]

Ok thank you! It's already added to the board, I'll track it carefully next time I'll be oncall!

[vv-monsalve]

Ty!