-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Rustfmt's wrap_comments option? #176
Comments
As indicated, I expected this to automatically checked. No strong opinion however, where are ASCII art examples that would need refactoring? |
It'd be easier to have an exhaustive list while reviewing code, but for a start |
Just wanted to know if you have an intuition about how much we have to change. But it seems like our code would be nicer with correct length comments? But I'd say it's low priority. |
As pointed out in #165 (comment), we currently allow comments that exceed the maximum line length normally allowed by Rustfmt.
We could enable the
wrap_comments
option inrustfmt.toml
to make sure the comments don't exceed this maximum length, and are wrapped properly. This however requires a few things.wrap_comments
option is currently unstable ([unstable option] wrap_comments rust-lang/rustfmt#3347), so we have to decide if we want to commit to using it.The text was updated successfully, but these errors were encountered: