-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Each run of test.sh
is very slow
#1091
Comments
I am surprised that the issue could be the installation of packages. In any case, if you have a solution that brings the tests down to 1 minute locally, we may at least add an option like a --local flag to prevent the cleanup and add the test_venv to the gitignored files. @fabianp may also know better on such issues. |
@vroulet Yes, that kind of caching might be contributing to the speedup as well. |
we could also have different scripts for {pytype, tests, building and testing documentation}, this way they could be run in parallel in github actions |
On my machine, each run of
sh test.sh
takes about 4.5 minutes, which is inconvenient for development.One potential way to make it faster could to keep a gitignored
test_venv
directory at the root of the repo that persists from run to run (that is, is not cleaned up bytest.sh
), so that all thepip install
packages used bytest.sh
don't need to be reinstalled on each run.Doing this brings the runtime down to 1 minute on my machine (after the initial run that installs all the packages). I can submit a PR demonstrating the changes, if desired. I'm also happy to hear any other suggestions.
The text was updated successfully, but these errors were encountered: