Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Shaper text #55

Open
justinchuby opened this issue May 18, 2024 · 3 comments
Open

[Feature Request] Shaper text #55

justinchuby opened this issue May 18, 2024 · 3 comments
Assignees
@jinjingforever @pkgoogle
Labels
front-end For issues where the root is mostly occurring on the front-end priority 2 This issue is recognized and will likely not be completed until after the next release stat:awaiting model-navigator The issue is actively being worked on by our navigators type:feature Feature requests

Comments

@justinchuby
Copy link
Contributor

justinchuby commented May 18, 2024 •
edited
Loading

Shown in #54, netron is able to display the graph more clearly using the same screen real estate. Things are more legible.

1v1 comparison

image image
@justinchuby
Copy link
Contributor Author

Model: https://github.com/onnx/models/blob/main/validated/text/machine_comprehension/gpt-2/model/gpt2-10.onnx

@pkgoogle pkgoogle added the type:feature Feature requests label May 20, 2024
@pkgoogle pkgoogle self-assigned this May 22, 2024
@pkgoogle
Copy link
Contributor

pkgoogle commented Jun 3, 2024

Hi @justinchuby, I think I agree in this case conciseness helps as most people don't think about the constant ops/initializer ops -- wondering if this should be an option -- like "hyper-detail" option or simply make those nodes have another level of double-clickability. Either way we'll look into it.

@justinchuby
Copy link
Contributor Author

I think displaying constants are ok. Even zooming out more Netron was able to render text more clearly. Maybe something to do with antialiasing in OpenGL? I am by no means an expert. A heavier font weight may help?

@pkgoogle pkgoogle added the priority 2 This issue is recognized and will likely not be completed until after the next release label Jun 4, 2024
@pkgoogle pkgoogle added stat:awaiting model-navigator The issue is actively being worked on by our navigators front-end For issues where the root is mostly occurring on the front-end labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinjingforever jinjingforever

@pkgoogle pkgoogle

Labels
front-end For issues where the root is mostly occurring on the front-end priority 2 This issue is recognized and will likely not be completed until after the next release stat:awaiting model-navigator The issue is actively being worked on by our navigators type:feature Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jinjingforever @justinchuby @pkgoogle