Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: Fix 2 image file cache key issues #13274

Merged
merged 1 commit into from
Jan 18, 2025
Merged

resources: Fix 2 image file cache key issues #13274

merged 1 commit into from
Jan 18, 2025
+341 −232

Conversation

bep
Copy link
Member

@bep bep commented Jan 16, 2025 •
edited
Loading

  • Make the content hash key to be the base image (in a chain), which will be more effective, I think.
  • Always include the content hash in the cache key.
  • Always include the image config hash in the cache key.

Fixes #13273
Fixes #13272

@bep bep marked this pull request as draft January 16, 2025 20:57
@bep bep force-pushed the fix/imagecacheissues-13272-13273 branch 5 times, most recently from 9f601b0 to 99965de Compare January 17, 2025 16:52
@bep
resources: Fix 2 image file cache key issues
2b259d0 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
@bep bep force-pushed the fix/imagecacheissues-13272-13273 branch from 99965de to 2b259d0 Compare January 18, 2025 10:30
@bep bep marked this pull request as ready for review January 18, 2025 11:18
@bep bep merged commit 1f5a15a into gohugoio:master Jan 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bep