Metric harbor_artifact_pulled should be Counter type, not Gauge

[Gypsying]

• harbor version: [2.5.3]

[Gypsying]

#14223

@mohitsharma-in
@yanji09
@phin1x

[phin1x]

the definition of a counter (from https://prometheus.io/docs/concepts/metric_types/#counter):
A counter is a cumulative metric that represents a single monotonically increasing counter whose value can only increase or be reset to zero on restart. For example, you can use a counter to represent the number of requests served, tasks completed, or errors.

the pulled values never goes down (why should it), so counter is the correct type. mabye you missing the rate or irate function.

[Gypsying]

the definition of a counter (from https://prometheus.io/docs/concepts/metric_types/#counter): A counter is a cumulative metric that represents a single monotonically increasing counter whose value can only increase or be reset to zero on restart. For example, you can use a counter to represent the number of requests served, tasks completed, or errors.

the pulled values never goes down (why should it), so counter is the correct type. mabye you missing the rate or irate function.

Of course, harbor_artifact_pulled should be counter type,
but the metric harbor exposed is Gauge, code definition

[chlins]

You may notice that the harbor_artifact_pulled is a metric crawled by the harbor exporter component, so the value is fetched from the database query, and the Counter type we should call the Inc() method if the artifact to be pulled each time, here the scenario is not that case, as the value in fact is a momentary value queried from database, so here this type we used the Guage type.

[github-actions]

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.