You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest renaming AddData to AddItem and AddDatas to AddItems. The word "data" is already plural, so datas is not a standard word in English. Adding an -s is grammatically incorrect.
The word data comes from Latin, where:
Datum is the singular form, meaning "a given fact" or "a single piece of information."
Data is the plural form, referring to multiple facts or pieces of information.
so AddDatas is redundant and may cause confusion. AddItem and AddItems would be clearer and more consistent with common naming conventions.
I suggest renaming
AddData
toAddItem
andAddDatas
toAddItems
. The word "data" is already plural, sodatas
is not a standard word in English. Adding an-s
is grammatically incorrect.The word data comes from Latin, where:
so
AddDatas
is redundant and may cause confusion.AddItem
andAddItems
would be clearer and more consistent with common naming conventions.In
client/request.go
func (r *Request) AddFormData
→func (r *Request) AddFormItem
func (r *Request) AddFormDatas
→func (r *Request) AddFormItems
func (r *Request) SetFormData
→func (r *Request) SetFormItem
func (r *Request) SetFormDatas
→func (r *Request) SetFormItems
func (r *Request) SetFormDatasWithStruct
→func (r *Request) SetFormItemsWithStruct
func (r *Request) DelFormDatas
→func (r *Request) DelFormItems
func (f *FormData) AddDatas
→func (f *FormData) AddItems
func (f *FormData) SetDatas
→func (f *FormData) SetItems
func (f *FormData) SetDatasWithStruct
→func (f *FormData) SetItemsWithStruct
func (f *FormData) DelDatas
→func (f *FormData) DelItems
In PR #3255, it was decided to make the following changes:
func (r *Request) AddFormData
→ Not changedfunc (r *Request) AddFormDatas
→func (r *Request) AddFormDataWithMap
func (r *Request) SetFormData
→ Not changedfunc (r *Request) SetFormDatas
→func (r *Request) SetFormDataWithMap
func (r *Request) SetFormDatasWithStruct
→func (r *Request) SetFormDataWithStruct
(removes
)func (r *Request) DelFormDatas
→func (r *Request) DelFormData
(removes
)func (f *FormData) AddData
→func (f *FormData) Add
(keep consistent withfasthttp.Args
)func (f *FormData) SetData
→func (f *FormData) Set
(keep consistent withfasthttp.Args
)func (f *FormData) AddDatas
→func (f *FormData) AddWithMap
func (f *FormData) SetDatas
→func (f *FormData) SetWithMap
func (f *FormData) SetDatasWithStruct
→func (f *FormData) SetWithStruct
func (f *FormData) DelDatas
→func (f *FormData) DelData
(removes
)The text was updated successfully, but these errors were encountered: