Update nextjs and data packages to ESM #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agerard-godaddy
force-pushed
the
next-data-esm
branch
from
de72124
to
285011a
Compare
mmason2-godaddy
approved these changes
May 31, 2024
kbader-godaddy
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gets nextjs and data packages ESM-ready. Next Document-specific functions move to separate document export path. The
withGasketDataHOC now works with functional document components.The
@gasket/datapackage now exports agasketData()function for more straightforward import and interface.Supporting GasketActions and related documentation will need to be added with a fuller refactor to
@gasket/plugin-response-data.Changelog
@gasket/data
gasketData()lookup function@gasket/nextjs
withGasketDataworks with functional componentsTest Plan
Locally tested in Next 14 app