Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw dismissible admin notice if we find a font awesome collision #42

Open
jonathanbardo opened this issue Feb 23, 2017 · 2 comments
Open
Milestone

Comments

@jonathanbardo
Copy link
Member

Plugins like WP Tiles uses an older version of Font Awesome in the admin which cause collision with the newer version we are using.

We should check for common patterns in style registration and throw an admin notice if we find a possible collision. The admin notice should be dismissible by an admin.

@fjarrett
Copy link
Member

@fjarrett fjarrett added this to the 1.6.0 milestone Feb 23, 2017
@fjarrett
Copy link
Member

@jonathanbardo Perhaps a better way to "detect" Font Awesome would be to scan the global $wp_scripts['registered'] array for paths to font-awesome*.css? It seems more likely that plugins will not register a consistent script handle, and less likely that they would change the stylesheet file name.

@EvanHerman EvanHerman modified the milestones: 1.6.0, 2.0.0 Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants