Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code bug in C++ when deleting an item #2

Open
Kanellaman opened this issue Feb 26, 2024 · 0 comments
Open

Error code bug in C++ when deleting an item #2

Kanellaman opened this issue Feb 26, 2024 · 0 comments

Comments

@Kanellaman
Copy link

After deleting successfully an item from keychain an error code is raised resulting in exception in C# code.

I run on this problem while testing the C# code on Windows.

Program.cs

using System;
namespace KeySharp
{
    internal class Program
    {
        static void Main(string[] args)
        {
            Keyring.SetPassword("Lalala", "Test", "thisuser", "Neone");
            try
            {
                var password = Keyring.GetPassword("Lalala", "Test", "thisuser");
                Console.WriteLine(password);
            }
            catch (KeyringException ex)
            {
                Console.WriteLine(ex.Message);
            }
            Keyring.DeletePassword("Lalala", "Test", "thisuser");
        }
    }
}

Output:

Neone

Unhandled Exception: KeySharp.KeyringException:  (NoError)
   at KeySharp.Keyring.ThrowLastError() in C:\Users\user\Source\Repos\KeySharp\KeySharp\Keyring.cs:line 114
   at KeySharp.Keyring.DeletePassword(String package, String service, String username) in C:\Users\user\Source\Repos\KeySharp\KeySharp\Keyring.cs:line 84
   at KeySharp.Program.Main(String[] args) in C:\Users\user\Source\Repos\KeySharp\KeySharp\Program.cs:line 18

The fix I am suggesting is changing the 50th line of main.cpp to if (error->type != keychain::ErrorType::NoError) similar to other functions.
I have not actually tested the change I am suggesting but I am pretty sure this is where the error occurs(I'll try to re-compile the C++ code to test it). It would be awesome if you could verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant