Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add revive #937

Open
dveeden opened this issue Oct 28, 2024 · 1 comment
Open

CI: Add revive #937

dveeden opened this issue Oct 28, 2024 · 1 comment

Comments

@dveeden
Copy link
Collaborator

dveeden commented Oct 28, 2024

Using revive as linter might be good. However this would need a reasonable config and probably fixing of some issues like missing comments on exported functions.

@lance6716 @atercattus what do you think?

@lance6716
Copy link
Collaborator

Do you mean turn on revive in current CI framework

golangci:
name: golangci
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: latest
args: --timeout=3m

https://golangci-lint.run/usage/linters/#revive

LGTM then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants