Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[canal] add a skip prepareDumper() logic #922

Open
zhujintao opened this issue Oct 12, 2024 · 2 comments
Open

[canal] add a skip prepareDumper() logic #922

zhujintao opened this issue Oct 12, 2024 · 2 comments
Labels

Comments

@zhujintao
Copy link

exec: "mysqldump": executable file not found in $PATH

	if err = c.prepareDumper(); err != nil {
		return nil, errors.Trace(err)
	}

use custom full import, non mysqldump
add skipDump logic:

	if !c.cfg.skipDump {
		if err = c.prepareDumper(); err != nil {
			return nil, errors.Trace(err)
		}
	}
@rockwotj
Copy link

rockwotj commented Dec 3, 2024

Yeah it would be cool to replicate what mysqldump does in go instead of shelling out

@dveeden dveeden added the canal label Dec 3, 2024
@dveeden
Copy link
Collaborator

dveeden commented Dec 3, 2024

I think adding a skipDump option could be useful. Replacing mysqldump/mariadb-dump would be welcome, but it is also a lot of work to get that working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants