Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartHeatbeat should send error if resp.Code is not 0 #73

Open
ranggarmaste opened this issue May 8, 2024 · 1 comment
Open

StartHeatbeat should send error if resp.Code is not 0 #73

ranggarmaste opened this issue May 8, 2024 · 1 comment

Comments

@ranggarmaste
Copy link

err = bot.StartHeartbeat() will not return error if StartHeartBeat returns response with non-0 Code, and then it will send TenantAppAccessToken as an empty string

I think we should throw an error instead for the first attempt of GetAccessTokenInternal? I encountered a stupid error of setting up the app_id wrongly and it took me a while to figure out

@crispgm
Copy link
Contributor

crispgm commented May 14, 2024

This idea looks reasonable. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants