Help needed with AfterJobRunsWithError configuration

[lays147]

Hi, I have the following job definition:

_, err := scheduler.NewJob(
		gocron.DurationJob(interval),
		gocron.NewTask(func() {
			handler.RunReceivableWindowsWorker(ctx, maxWindowSize)
		}),
		gocron.WithEventListeners(
			gocron.AfterJobRunsWithError(func(jobID uuid.UUID, jobName string, err error) {
				log.Error().Err(err).Msg("Receivable Windows Worker failed execution.")
			}),
		),
		gocron.WithSingletonMode(gocron.LimitModeReschedule),
	)

I'm wondering why the AfterJobRunsWithError is not being triggered, since the invocation of the handler is returning an error. Am I missing something?

Cheers,

[JohnRoesler]

Hi @lays147

You'll need to capture and return the error from the handler, similar to this test https://github.com/go-co-op/gocron/blob/v2/scheduler_test.go#L1778-L1785

Assuming handler.RunReceivableWindowsWorker(ctx, maxWindowSize) returns only 1 argument, an error, you could do

_, err := scheduler.NewJob(
		gocron.DurationJob(interval),
-		gocron.NewTask(func() {
+		gocron.NewTask(func() error {
-			handler.RunReceivableWindowsWorker(ctx, maxWindowSize)
+			return handler.RunReceivableWindowsWorker(ctx, maxWindowSize)
		}),
		gocron.WithEventListeners(
			gocron.AfterJobRunsWithError(func(jobID uuid.UUID, jobName string, err error) {
				log.Error().Err(err).Msg("Receivable Windows Worker failed execution.")
			}),
		),
		gocron.WithSingletonMode(gocron.LimitModeReschedule),
	)

[lays147]

Hi @JohnRoesler thanks! That worked!
Would you mind updating the docs to reflect this? Because the example doesn't reflect what you've told me.

[JohnRoesler]

Feel free to submit a PR!