Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On each highlight audio and favicon is requested from server #1149

Open
JeremyMahieu opened this issue Jul 21, 2020 · 2 comments
Open

On each highlight audio and favicon is requested from server #1149

JeremyMahieu opened this issue Jul 21, 2020 · 2 comments
Labels

Comments

@JeremyMahieu
Copy link
Contributor

Each time someone highlighted, sonar.ogg and glowing_bear_128x128.png are requested from the server. The sound still plays and the favicon still updates before the request is done. Even if the resource is not available anymore everything still works. If the resource is not available sonar.mp3 is still requested.

image

Doing two highlights while server is offline:
image

@JeremyMahieu
Copy link
Contributor Author

If it manages to load once, it does come from disk cache. The "Disable cache" checkbox was off when I did the requests on the screenshots but it seems to keep missing cache untill a reload because of that checkbox. Still I don't think the should be reloaded each time, should it?

@lorenzhs lorenzhs added the bug label Jul 22, 2020
@lorenzhs
Copy link
Member

It definitely shouldn't, thanks. We should look into fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants