-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockComponent is recreated when special char is typed in the main editor #384
Comments
Update: It seem's that the problem still comes with the version under
You'll see again the |
ImageBlock gets added as a plugin here: megadraft/src/components/MegadraftEditor.js Line 121 in 1caecd3
I also looked at the keybindings and couldn't find any default bindings that could cause this issue for you. I also couldn't replicate it myself ALso, noticed opportunity for minor improvement on these components so opened a PR for them: #406 |
-- Bug Report --
Expected Behavior
The
blockComponent
shouldn't be re-created all timesCurrent Behavior
Since the version
0.7.0
theblockComponent
is always re-created when you write a special character likeê
,ë
(combinaison of two keyboard keys to being added).Steps to Reproduce
Go to : https://codesandbox.io/s/megadraft-with-plugins-and-example-content-forked-ck83pb?file=/src/index.js
ImageButton mount ...
andImageBlock mount ...
ê
multiple times and see the console, theImageBlock
component is re-created for each character...megadraft
under the0.7.0
, and type the special character, you can see the expected behaviorBrowser, device, and OS
Screenshots
The text was updated successfully, but these errors were encountered: