-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDZ ReferenceError
with 2.0.0-beta.8
#302
Comments
@pzuraq - Have any time to poke at this? |
I see this error when booting a fresh app after running |
looks like it's may be fixed by #305 |
it seems like something odd is happening due to the fact that we don't pin to an exact version of packages in the VM, but do here. We should probably start pinning exact versions everywhere, where it matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was playing with updating the GlimmerX packages to use the recent 2.0.0-beta.8 release here (still on my sisyphean quest to escape the
MonomorphicTagImpl
type error), but its test suite no longer boots. While the module graph is initializing, an error is thrown along these lines:This turns out to be a TDZ error, where
scheduleRevalidate
is seemingly called before that point in the module body has actually been executed:glimmer.js/packages/@glimmer/core/src/render-component/index.ts
Lines 84 to 88 in c168354
Poking around a little bit, I'm not positive what the problem is, but there's a suspicious circular dependency between the
core/src/environment/delegates
module andcore/src/render-component
. The top of the stack when the error occurs is this module-scope warmup code in@glimmer/validator
, which also points toward a circular dependency/half-instantiated-module problem.My guess is that this is sensitive to the order modules are resolved in, which would explain why it hasn't cropped up in the tests in this repo, but here's the GlimmerX branch where I ran across this:
glimmerjs/glimmer-experimental@master...dfreeman:update-glimmer-dependencies
The text was updated successfully, but these errors were encountered: