Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Search Bar #93

Open
Pi-Cla opened this issue May 3, 2024 · 5 comments
Open

Add a Search Bar #93

Pi-Cla opened this issue May 3, 2024 · 5 comments

Comments

@Pi-Cla
Copy link

Pi-Cla commented May 3, 2024

It would be cool if we could add a search bar to the language tour (and potentially the rest of the website) to quickly look things up since the language tour currently serves as a de facto reference to the core language.

@lpil
Copy link
Member

lpil commented May 3, 2024

What would this give that the content page does not?

@Pi-Cla
Copy link
Author

Pi-Cla commented May 3, 2024

What would this give that the content page does not?

Hmm... let me try to explain what my brain is feeling.
My brain is the type of brain that is used to searching things up via grepping. It likes being able to type text into a bar and being able to see answers. It does not like having to spend the extra effort to go through a whole table of contents.

This is just a subjective feeling, but this is the reason why I want to see this through. (I am interested in implementing this myself)

@lpil
Copy link
Member

lpil commented May 3, 2024

It likes being able to type text into a bar and being able to see answers

I do this today by using the browser's search on the contents, or the everything page if I want to be on that page. What would be the difference there?

Not trying to be a pain, just always on the lookout for efficient solutions seeing as we have so little developer-time and just answering all the issues and PRs takes most my day at the moment.

@xxKeefer
Copy link
Contributor

I feel this is related to this issue for the website. long term it would be nice if the these search bars being discussed were the same solution but perhaps that's more heavy duty than what's required here.

I agree though that the control + F on the everything page is probably sufficient but the link to the everything page is kind of hidden. Maybe it would be nice to have a button link thing in the top right of the tour near the theme switcher that links to the everything page?

@lpil
Copy link
Member

lpil commented May 14, 2024

There's not enough space there on mobile to add a link. Some more involved design work would need to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants