feat: ✨ add examples of record pattern matching #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Wonderful, thank you.
There's no such thing as destructuring in Gleam, that's a JavaScript term. In Gleam we pattern match.
Pattern matching has already been explained, so we don't need to explain what it is, but we do want to explain that:
letcan only be used with single variant custom types- Labels can be used
- The
..spread operator can be used to match on only a portion of the fields.
It might be good to show _ but I don't think we need to explain it as it has been covered by previous lessons.
lpil
reviewed
Apr 25, 2024
src/content/chapter3_data_types/lesson04_record_destructuring/code.gleam
Outdated
Show resolved
Hide resolved
src/content/chapter3_data_types/lesson04_record_destructuring/code.gleam
Outdated
Show resolved
Hide resolved
|
thanks for the feedback @lpil hopefully this is looking better 👍🏻 |
xxKeefer
changed the title
lpil
reviewed
May 20, 2024
src/content/chapter3_data_types/lesson04_record_pattern_matching/en.html
Outdated
Show resolved
Hide resolved
| </p> | ||
| <p> | ||
| It is possible to use underscore <code>_</code> or the spread syntax <code>..</code> to | ||
| discard fields that are not required. |
There was a problem hiding this comment.
It would be good to explain the difference between them here, and show the difference in the code example.
src/content/chapter3_data_types/lesson04_record_pattern_matching/en.html
Outdated
Show resolved
Hide resolved
lpil
approved these changes
Jun 12, 2024
use correct terms, clean up code example, explain everything that need to be gleam-lang#56
Co-authored-by: Louis Pilfold <[email protected]>
lpil
force-pushed
the
issue-56_record-destructuring-example
branch
from
8cef99a
to
29f06ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #56 by adding examples of record destructuring to the tour