Add gleam hex revert #3079
Add gleam hex revert #3079
Conversation
|
I did some live testing on my gling package and it looks like it worked! :D |
Pi-Cla
force-pushed
the
publish-revert
branch
2 times, most recently
from
e0055b5
to
f75626b
Compare
|
I ended up having to make revert a subcommand because if I tried to make it like: where --revert and [VERSION] is optional then I end up with the type This would then require that whenever any part of the code was processing the full double option to add a line to silence clippy else clippy would complain. |
Thanks for doing this! |
Pi-Cla
force-pushed
the
publish-revert
branch
2 times, most recently
from
5562360
to
8f2f9c9
Compare
Oh I missed this comment. Ok now it matches the other |
Pi-Cla
force-pushed
the
publish-revert
branch
3 times, most recently
from
b812871
to
f8c81ce
Compare
compiler-wasm/Cargo.toml
Outdated
| @@ -22,6 +22,7 @@ itertools.workspace = true | |||
| serde.workspace = true | |||
| termcolor.workspace = true | |||
| tracing.workspace = true | |||
| getrandom.workspace = true | |||
There was a problem hiding this comment.
How come this has been added? This package is unmodified and doesn't use random numbers afaik
There was a problem hiding this comment.
This is from the required update to the latest version of hexpm-rust. After the dependencies in hexpm-rust were bumped there was a new indirect dependency added getrandom which required the js flag to be added in order for builds on the wasm32-unknown-unknown target to work. I added comments to the root Cargo.toml to explain this:
Lines 61 to 62 in 218ebb0
Edit: I need to add a mention to the workspace getrandom to at least one of the crate level Cargo.tomls or else the js flag does not actually get factored into dependency handling and then the wasm32-unknown-unknown build fails. And since the transitive dependencies come fromgleam-wasm I have added it there.
There was a problem hiding this comment.
Also this diff is inaccurate now because the PR that updates the CI got merged which also required this same hexpm-rust bump. So this PR now has no additional effect on this stuff. I have rebased this PR to give an updated diff
A new package can be reverted or updated within 24 hours of it's initial publish, a new version of an existing package can be reverted or updated within one hour. Resolves gleam-lang#3019
A new package can be reverted or updated within 24 hours of it's initial publish, a new version of an existing package can be reverted or updated within one hour.
Resolves #3019