Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Configure PVC storage request for Gitlab #529

Open
1 task done
jrab66 opened this issue Feb 23, 2024 · 0 comments
Open
1 task done

[Feature]: Configure PVC storage request for Gitlab #529

jrab66 opened this issue Feb 23, 2024 · 0 comments

Comments

@jrab66
Copy link

jrab66 commented Feb 23, 2024

Checklist

  • I've searched for similar issues and couldn't find anything matching

Is this feature request related to a problem?

None

Problem Description

I want to create a proper instance of gitlab with both data and db volumes besides the default, at least on db I did find the config to dry that one.

spec:
  database: 
    storage: 
      size: 21Gi

but checking the code for the operator/src/main/kotlin/eu/glasskube/operator/apps/gitlab/dependent/GitlabVolume.kt
,seems to be picking default without allowing change,

            resources {
                requests = mapOf(
                    "storage" to Quantity("20", "Gi")
                )

I did find some similar feature covered over : https://github.com/glasskube/operator/pull/510

i will check to try to make the changes but I not a kotlin guy whatsoever so I will appreciated if someone can take a look after some PR.

Solution Description

We need to create the changes to this files I imagine:

  • operator/src/main/kotlin/eu/glasskube/operator/apps/gitlab/dependent/GitlabVolume.kt
  • operator/src/main/kotlin/eu/glasskube/operator/apps/gitlab/GitlabSpec.kt

Benefits

have proper settings for gitlab-data pvc.

Potential Drawbacks

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant