Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Fixes #53 fix the broken link. #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nisarhassan12
Copy link
Contributor

@nisarhassan12 nisarhassan12 commented Apr 13, 2020

Fixes #53

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, many thanks @nisarhassan12!

I made two suggestions in-line.

README.md Outdated
@@ -5,7 +5,7 @@ This repository contains externally maintained `.gitpod` files for projects on G

The files are organized by repository name. If you need a different configuration for a fork the repository folder can contain a folder for the organisation.

The configuration format is explained [here](https://docs.gitpod.io/40_Configuration.html#gitpod-file).
The configuration format is explained [here](https://www.gitpod.io/docs/configuration/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But actually, re-reading this sentence, I don't think that the configuration format is explained in https://www.gitpod.io/docs/configuration/ (that page seems to be more about the Setup Assistant / the general configuration process, as opposed to the specific .gitpod.yml format).

Maybe linking to https://www.gitpod.io/docs/config-gitpod-file/ would be more relevant / helpful here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I notice that the paragraph above talks about a .gitpod file. I think this is outdated information, because this file is now called .gitpod.yml. 😄 Could you please fix it as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have fixed it 🙂

@jywarren
Copy link

jywarren commented Jul 5, 2020

Hi, i was trying to find a comprehensive list of settings configurable in the .gitpod.yml file. Could someone help me find that? Also, maybe that's a good one to link to from here as well! Thank you!!!!

@@ -1,11 +1,11 @@
# External Gitpod Configuration

[Gitpod](https://gitpod.io) is an online IDE for GitHub.
This repository contains externally maintained `.gitpod` files for projects on GitHub.
This repository contains externally maintained `.gitpod.yml` files for projects on GitHub.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jankeromnes Are we gonna have separate definitely-gp repos for other platforms like GitLab and Bitbucket?

@nisarhassan12
Copy link
Contributor Author

Hi, i was trying to find a comprehensive list of settings configurable in the .gitpod.yml file. Could someone help me find that? Also, maybe that's a good one to link to from here as well! Thank you!!!!

@jankeromnes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link "here" points to a 404.
4 participants