-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Flags support #707
Comments
Thanks for the idea @glensc . I think it should probably be another top-level key under a project similar to |
Thanks for all that details @glensc . I haven't used GitLab's "Feature flags" yet, but here's my thought. I like your config syntax suggestion. One minor tweak I would propose is to not have the projects_and_groups:
group_1/project_1:
feature_flags:
awesome_feature:
- name: awesome_feature
description: "This feature is about merge train"
active: true,
- scopes: [] The reason for removing
I'm not too clear or maybe on the fence on this. I think gitlabform should perform based on whatever is in the config. If As for the config syntax related to projects_and_groups:
group_1/project_1:
feature_flags:
awesome_feature:
description: "This feature is about merge train"
active: true,
strategies:
- strategy-foo: # This is just a label
name: gradualRolloutUserId
parameters:
groupId: default
percentage: 25
scopes:
- environment_scope: staging
- strategy-bar: # This is just a label
name: gradualRolloutUserId
parameters:
groupId: default
percentage: 35
scopes:
- environment_scope: qa Maybe the |
if it works like this, then perfect. but if will overwrite active state, I can't possibly use this feature. the use case is like this:
I don't know how to better explain this use case. |
@glensc I agree with you, toggling on/off a Feature Flag is something we do want people to be able to quickly do in UI without GLF reverting, for example: I create the Feature Flag as "off", We should allow people to set "active" in the config and if it's there use it to apply that to Gitlab itself even if there is drift. But if people do not set "active" in the config:
|
GitLab has feature flags:
API description:
I can't seem be able to find feature flags from the feature list:
nor from issues or pull requests:
please add support controlling feature flags:
The text was updated successfully, but these errors were encountered: