Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script/create-files: if Day 1 collaborator's name contains a name of Day 1 repo admin -> the attendees files and repos are NOT created #365

Open
RinatS opened this issue May 24, 2022 · 0 comments

Comments

@RinatS
Copy link

RinatS commented May 24, 2022

Found by @chrisn555-im:
Fixed issue where if another users name is a prefix of the repo owner, no files are created

diff --git a/script/create-files b/script/create-files
index 4a235707..8892318a 100755
--- a/script/create-files
+++ b/script/create-files
@@ -23,7 +23,7 @@ add_collaborators() {
echo -e "\nAdding collaborators..."
for commenter in "${commenters[@]}"; do
# Check if commenter is already a collaborator

  • if [[ ${collaborators[*]:?} == "${commenter}" ]]; then
  • if [[ " ${collaborators[*]} " =~ " ${commenter} " ]]; then
    existing_collaborators+=("$commenter")
    else # Add collaborator
    curl -s -S -i -u "$TOKEN_OWNER:$TEACHER_PAT”\
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant